search

nxp-mcuxpresso / rpmsg-lite

RPMsg implementation for small MCUs
BSD 3-Clause "New" or "Revised" License
228 stars 73 forks source link

Feature/static api #14

Closed Hadatko closed 3 years ago

Hadatko commented 3 years ago

Hi @MichalPrincNXP , this is WIP PR. It is not best and it is touching other platforms/env. I was working in nxp directory structure so some cases, which are now different (some files are generic here, but in nxp repo they looked env/platform specific) need be fixed. Could you propose me suggestions for this PR? Thank you.

Related to #13

MichalPrincNXP commented 3 years ago

Hi Dusan, thank you, the proposal looks ok to me. I have couple of comments that will be added into the code review.

MichalPrincNXP commented 3 years ago

Also, I am afraid we could get into troubles when having multiinstance. I am writing it here as this needs to be analyzed.

Hadatko commented 3 years ago

Also, I am afraid we could get into troubles when having multiinstance. I am writing it here as this needs to be analyzed.

Sure, from my point of you, it shouldn't be worse or better now in multiinstance case. I was trying to keep static context in same scope as semaphore, mutex,...

MichalPrincNXP commented 3 years ago

Dusan, as per this instruction, could you please allow me to edit this PR. I would like to pass the update from my side to be reviewed and tested by you? Do you agree? Thank you.

Hadatko commented 3 years ago

Sure, i agree, just i don't see simple way how can you push directly to this branch.

Hadatko commented 3 years ago

I cannot see the checkbox for allowing that. Maybe due to: https://github.com/isaacs/github/issues/1681

Hadatko commented 3 years ago

Is it ok now?

MichalPrincNXP commented 3 years ago

Is it ok now?

I think so, let me retest on my side once again, ok?

Hadatko commented 3 years ago

Sure.

MichalPrincNXP commented 3 years ago

Thank you for the effort, Dusan!