search

nxp-mcuxpresso / rpmsg-lite

RPMsg implementation for small MCUs
BSD 3-Clause "New" or "Revised" License
238 stars 73 forks source link

rpmsg_lite_wait_for_link_up should be extended with timeout #25

Closed Hadatko closed 1 year ago

Hadatko commented 2 years ago

I am suggesting to extend rpmsg_lite_wait_for_link_up with one parameter uint32_t timeoutMs and return value -> true/false So user can insert max time to wait in ms and return true/false based on link is up or not.

MichalPrincNXP commented 2 years ago

Good point. Unfortunately, we already passed the feature freeze date so I can prepare the update but not be used in coming v4.0.0

Hadatko commented 2 years ago

No problem. Personally i don't need it. I saw NXP example where it make sense likely (app_srtm related). But generally it make sense to let user define timeout. If you would do it into this release you don't have to solve backward compatibility. I am just sharing this idea ;)

MichalPrincNXP commented 2 years ago

Yes, agree but the date is gone, unfortunately. Anyway, will provide this in the further release. Thanks for this idea.

MichalPrincNXP commented 1 year ago

Resolved in https://github.com/nxp-mcuxpresso/rpmsg-lite/releases/tag/v5.0.0