search

nxp-mcuxpresso / spsdk

Secure Provisioning SDK (SPSDK) is unified, reliable and easy to use SW library working across NXP MCU portfolio providing strong foundation from quick customer prototyping up to production deployment.
Other
55 stars 24 forks source link

Support cryptography >= 37.0.0 #43

Closed dvzrv closed 2 years ago

dvzrv commented 2 years ago

Fixes #42

dvzrv commented 2 years ago

Related: I think it would be best to completely circumvent wildcard imports such as the one I removed: https://github.com/NXPmicro/spsdk/blob/c3c7fb241acb23977651a9970e25230b69dac52f/spsdk/crypto/__init__.py

If there are issues with mypy, then it either needs to be configured differently or typing issues need to be ignored.

dvzrv commented 2 years ago

@mwsk It would be really helpful to get feedback on these types of PRs, as they are vital for downstreams. Incorporating changes on a large scale from version to version is neither transparent nor helpful and shuts out any external contributor from this project :cry:

marekvi95 commented 2 years ago

Hello @dvzrv, thanks for your PR. I have tested cryptography 37 and 38 and it seems that everything is working as expected. The only downside is quite a significant slowdown when operating with RSA keys. See https://github.com/pyca/cryptography/issues/7236

The next version of SPSDK will support cryptography 38+.