search

nxp-mcuxpresso / vscode-for-mcux

Support for NXP Visual Studio Code for MCUXpresso Extension project.
13 stars 0 forks source link

[SUGGESTION] Move root CMakelist out of armgcc folder #27

Open snellejelle99 opened 7 months ago

snellejelle99 commented 7 months ago

After converting my project from mcuxpresso eclipse I noticed the CMakelist root file is located in a subdirectory. This results in problems when using the add_subdirectory command since this can only be used on directory's that are subdirectory's of the cmakelist root folder.

My suggestion is changing the current cmakelist file to a .cmake file. Then create a CMakeList root file in the root folder which includes this .cmake file.

For some more context: By using add_subdirectory we can set different compile options and definitions for certain sections of code just as we could do in the MCUxpresso IDE. It also makes the Cmake files a bit more readable since it isn't one massive list of sources.

cristitep-nxp commented 7 months ago

Hi @snellejelle99,

You are right, we preserved the model from MCUXpresso SDK where CMakeLists.txt is under armgcc folder, armgcc being just one of the toolchain models provided under it. For projects converted from MCUXpresso IDE we can make the change you proposed, it is better to be like this. It will be available in a future release.

Thanks!

snellejelle99 commented 7 months ago

@cristitep-nxp Do you guys have a place to post suggestions? Or a roadmap of some kind? After working with this extension for a week i have quite a list by now.

cristitep-nxp commented 7 months ago

Hi @snellejelle99,

You can log in Issues here. Preferable to have separate issues if they are completely different topics in order to track them easier, but single issue for all will be fine too.

Regards and thanks for your interest, Cristian