nxpm / stack

🥭 nxpm-stack lets you generate a complete and opinionated full-stack application in a Nx Workspace, ready to extend and deploy!

https://npm.im/@nxpm/stack

MIT License

108 stars 14 forks source link

Remove unecessary sorts, add undefined check to packageJson sort #153

Closed kpaxton closed 2 years ago

kpaxton commented 2 years ago

Nx 13+ already handles sorting the TsConfig paths and Workspace projects so I've removed them from the command so this now only sorts the package.json scripts property now.

Added an undefined check to the sort function so that it doesn't add the property if it doesn't exist. Should never happen since package.json should always have the scripts property.

Fixes:

152

nx-cloud[bot] commented 2 years ago

☁️ Nx Cloud Report

CI ran the following commands for commit a9dcf5ced4e5ee538610aa135dbb1620c74200be. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 2 targets

- [`nx affected:e2e --base=remotes/origin/main`](https://nx.app/runs/SynrqPg3hPZ) - [`nx run-many --target build --all`](https://nx.app/runs/Iv7hVdAo2FN)

Sent with 💌 from NxCloud.

beeman commented 2 years ago

Merged in #154