nxpm / stack

🥭 nxpm-stack lets you generate a complete and opinionated full-stack application in a Nx Workspace, ready to extend and deploy!

https://npm.im/@nxpm/stack

MIT License

108 stars 14 forks source link

fix: default generated tests missed import for RouteGuards and a typo #75

Closed DominikPieper closed 3 years ago

nx-cloud[bot] commented 3 years ago

Nx Cloud Report

CI ran the following commands for commit 7915206f7798b319a8d7318e07d775a75b1617d4. Click to see the status, the terminal output, and the build insights.

Status	Command	Start Time
	`nx run-many --target build --all`	1/23/2021, 1:38:05 AM
	`nx run-many --target e2e --all`	1/23/2021, 1:38:10 AM
	`nx run-many --target test --all`	1/23/2021, 1:38:08 AM

Sent with 💌 from NxCloud.

beeman commented 3 years ago

Thanks a lot @DominikPieper! I'll soon activate running the unit tests too by default on the generated projects, so this comes in super handy!

DominikPieper commented 3 years ago

@beeman I'll take a look on some of the other tests later. On the login/logout/register tests there's a missing input I'd say. They can't resolve Auth-page (I think that was the one)

beeman commented 3 years ago

That would be definitely appreciated to have some more tests being generated!

The web-auth-feature tests should now run correctly after this commit https://github.com/nxpm/stack/commit/6c3bed3242dc4be6adf8e377017b9a4a41e4053a and a few other tweaks landed