search

nxpm / stack

🥭 nxpm-stack lets you generate a complete and opinionated full-stack application in a Nx Workspace, ready to extend and deploy!
https://npm.im/@nxpm/stack
MIT License
108 stars 14 forks source link

Rebuild @nxpm/stack using nx11 #77

Open beeman opened 3 years ago

beeman commented 3 years ago

Expected Behavior

@nxpm/stack should be built using Nx 11.

Current Behavior

@nxpm/stack is built using Nx 10.

Context

Currently this project is an @nrwl/nx-plugin created with v10. In v11, Nx changed a few things in the structure, mainly around naming schematics -> generators, builders -> executors, architects => targets, and possibly some more.

The generators, besides to having a new name, also have a new way to write them. The commands that run in the generator can now be simply await-ed which makes it (especially with a project like this) easier to write, debug and share them. Those that have worked with schematics probably feel why. In some ways schematics might be easier, but we can wrap around those.

The new version also allows for some structural changes, and will be split up into several packages.

DominikPieper commented 3 years ago

A question comes to my mind here. The nxpm/cli creates a workspace without versions pinned and the repo uses v10 and nx-plugin 10. Right now the cli creates a Nx 11 workspace with the Nx 10 plugin which could lead into problems

beeman commented 3 years ago

@DominikPieper that's a good point, in fact I already encountered some unexpected behavior when running my e2e tests.

I worked around this by installing the latest versions of the main tools inside the workspace that gets created for the e2e test.

Luckily, it looks like the generated project does not have any traces of being an Nx 10 workspace, so I think we should be good there.