Closed ghost closed 10 years ago
Hi Andreas! The funny thing is that I was just working on a similar PR for this feature. Also for an app that interacts with Meetup.com. You were faster. :)
My only suggestion is to add your new key (kNXOAuth2AccountStoreConfigurationCustomHeaderFields) to the NXOAuth2AccountStore h/m files. So it's easier to define it when configuring the shared store.
And authors, please accept this PR!
Best. George.
Hi George,
thanks for pointing that out. I just missed to commit the constants... ups ;-)
Best Andreas
@AndreasTextunes there are some problems with your code. Specially with the external browser flow. Do you mind if I send a new PR mixing your code and mine?
@ghvillasboas If it works for both of us sure.
This looks very useful indeed, I added a few very tiny tiny complaints.
If you fix those I will merge this in and it will be in the next minor release.
Yeah, cool :-) I'll change that complaints you have.
BTW: I didn't changed the NSAsserts... But I'll fix it anyway.
:+1:
Our server desires a oAuth-request with a POST MIME type of 'application/x-www-form-urlencoded'. In order to get it work with the OAuth2Client we needed to add the support of creating the desired POST request.
The OAuth2Client in this state will only work with application/x-www-form-urlencoded and the 'multipart/form-data'. More MIME types must be added if needed. But IMO this is a good start to do so.
If the (new) kNXOAuth2AccountStoreConfigurationCustomHeaderFields key is set in the NXOAuth2AccountStore configuration the all header fields of the resulting HTTP-Request are replaced with the value for this key.