search

nxtbgthng / OAuth2Client

Client library for OAuth2 (currently built against draft 10 of the OAuth2 spec)
855 stars 217 forks source link

Add guard to unsupported features of iOS 8 extensions #161

Closed damienrambout closed 9 years ago

damienrambout commented 9 years ago

iOS 8 extensions can define the NX_APP_EXTENSION macro (in Preprocessor Macros for instance) to avoid compiling unsupported features. In this case, [UIApplication sharedApplication] cannot be called inside an extension. If OAuth2Client is installed using Cocoapods 0.36.X, it won't compile without this change. Compiling an extension is possible if NX_APP_EXTENSION is defined (can be done using Podfile's post_install block) for the OAuth2Client target.

By the way, xcconfig files generated by Cocoapods have been updated for 0.36.1. Same goes for the Podfile.lock file.

Please merge and push a new version to Cocoapods as soon as you can, this issue is really blocking me (and maybe other users as well). Thanks.

damienrambout commented 9 years ago

Please merge this pull request ASAP, this is a critical issue when the project integrates an Apple Watch extension.

sirnacnud commented 9 years ago

I am also interested in getting this in, as I am trying to use it in a Today Widget.

toto commented 9 years ago

Thanks for the contribution :+1:

kevincador commented 9 years ago

Hey @toto

Could you please push a new version to Cocoapods?

I see that there are 36 new commits to develop since the latest Cocoapods version and at least two of the issues we have in our project have been fixed with them including this (big annoying) one.

Thanks a lot.