nxtend-team / nxtend

MIT License

189 stars 42 forks source link

fix(capacitor): project config param changes fix #631

Open nikita-yaroshevich opened 2 years ago

nikita-yaroshevich commented 2 years ago

Hotfix for https://github.com/nxtend-team/nxtend/issues/630

Description

PR Checklist

[ ] Migrations have been added if necessary
[ ] Unit tests have been added or updated if necessary
[ ] e2e tests have been added or updated if necessary
[ ] Changelog has been updated if necessary
[ ] Documentation has been updated if necessary

Issue

https://github.com/nxtend-team/nxtend/issues/630 Resolves #

andreiLita commented 2 years ago

@devinshoemaker can someone review this pull request ? This solves the capacitor nx plugin generator.

On another note, this repository is not up to date with the rest of nx. So migrating to the version 14 is required. For example the ionic-react application generator depends on node_modules/nx/src/utils/app-root. This file does not exist anymore in the current version of nx@14.2.4.

rhutchison commented 2 years ago

I am not sure if these changes are required.