search

nxxxu / AutoPixieWps

Automated pixieWps python script
342 stars 104 forks source link

Update autopixie.py #1

Closed d8tahead closed 9 years ago

d8tahead commented 9 years ago

Removed tailing " and XXXXXb == "": " from if "XXXXX" in line and XXXXXb == "": such, because will mix hash information. it is needed to start fresh each new attempt for proper usage

fixed some regex to hex only ranges [^A-Fa-f0-9]+ instead of un-needed [^A-Za-z0-9]+ non hex only ranges for hex values

nxxxu commented 9 years ago

i would challenge you on that, i dont see it doing what you say. because after the reaver() it deletes the reaver outputs, and when it starts to reave hashes from another client, it goes to reaver() and in the beginning there is hash="" and hashb="" wich empties them. im not saying if "E-Hash2" in line and EHash2b == "": is necessary, was implemented when it said in status, hash found, didnt want it to spam PKE/Authkey hash if it didnt recieve hash1-2

and re.sub('[^A-Fa-f0-9]+, i dont see it really making any difference.

i dont see the changes qould make any difference what so ever in the python script, i now changed that,, but i dont see any difference in the way it works. you are ofc welcome to explain why you think it would collide.. but yeah, its merged now.

2015-04-15 9:43 GMT+03:00 d8tahead notifications@github.com:

Removed tailing " and XXXXXb == "": " from if "XXXXX" in line and XXXXXb == "": such, because will mix hash information. it is needed to start fresh each new attempt for proper usage

fixed some regex to hex only ranges [^A-Fa-f0-9]+ instead of un-needed

[^A-Za-z0-9]+ non hex only ranges for hex values

You can view, comment on, or merge this pull request online at:

https://github.com/nxxxu/AutoPixieWps/pull/1 Commit Summary

  • Update autopixie.py

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/nxxxu/AutoPixieWps/pull/1.

d8tahead commented 9 years ago

I meant no offence, your code is good. But I've had some instances where it wouldn't clear them out. that was the reasoning behind me also putting the output of the full hashes on screen in the version I had posted on the forums. But then again I do have a few versions of reaver that I've modified for testing in different ways. Any who, if you see no difference in the output, then revert the change. But if anything, if it essentially is the same for you, it removes an unneeded check.

But you've done some great work, keep it up. :-)

d8tahead commented 9 years ago

As for the regex, it's just for probably not even barely noticeable performance reasons. all its doing is eliminating a check a-Z. All that is needed is to a-F. I run this script like many others on a tablet, not a nexus7, but an older a500. And I need to spare all the cpu cycles I can :-)