nyancodeid / laravel-8-stisla-jetstream

Laravel 8 + Jetstream + Livewire + Stisla
278 stars 131 forks source link

Question: why add tailwindcss? #19

Open lakuapik opened 2 years ago

lakuapik commented 2 years ago

As i browse the codebase, i found tailwindcss is added to this starter template.

Stilsa uses bootstrap 4 right?

Why add tailwindcss to the core?

If the use of tailwindcss is only for implementing some of jetstream ui, why not implementing this on boostrap and elevating the use of stilsa dashboard it self?

nyancodeid commented 2 years ago

Thats true, jetstream requires tailwindcss in its view. And I just realized that the bootstrap style would potentially clashed with the tailwind class. Unfortunately I don't have enough time to change jetstream pages using bootstrap 4.

kiryph commented 2 years ago

@nyancodeid What about using https://github.com/nascent-africa/jetstrap ?

nyancodeid commented 2 years ago

good solution, but I don't think we need any additional packages for now to refactor the jetstream component from tailwindcss to stisla.

kiryph commented 2 years ago

I was adding the link because of the mentioned time constrain:

Unfortunately I don't have enough time to change jetstream pages using bootstrap 4.

I can only reiterate what the OP already said:

https://github.com/nyancodeid/laravel-8-stisla-jetstream/blob/6a33bfb2178743362153807fa21c75b6389fdc08/package.json#L20

adds Tailwindcss 1.3 and

https://github.com/stisla/stisla/blob/dd804ea868595527736071926a20cf35afdd6621/package.json#L11

adds Bootstrap 4.2.

IMHO they should not be mixed in one project.

silicahd commented 2 years ago

I think the question should be, why have bootstrap and not just tailwind.

lakuapik commented 2 years ago

@silicahd you understand right that stisla is a bootstrap admin panel?

it says on its home page: