nyanpasu64 / j0CC-FamiTracker

(Archived, see https://github.com/Dn-Programming-Core-Management/Dn-FamiTracker) Numerous bugfixes for 0CC-FamiTracker (based off 0.3.14.5).
https://github.com/Dn-Programming-Core-Management/Dn-FamiTracker
GNU General Public License v2.0
15 stars 2 forks source link

Add global constant for app name and version string #115

Closed nyanpasu64 closed 6 years ago

nyanpasu64 commented 6 years ago

App name is found in name.h and included in stdafx.h. Version string is found in version.h.

Currently both are #define as string literals, which can be passed into _T(). Unfortunately this is a missed opportunity to reduce binary size slightly.

#define APP_NAME            "j0CC-FamiTracker"
#define VERSION_STR         ...
#define APP_NAME_VERSION    APP_NAME " " VERSION_STR

"0CC-FamiTracker.rc" does not use name.h. Unfortunately even if I edit the file to use parameterized name/version, it will be erased by VS's resource editor. Maybe I could move all strings... and menus... and dialogs? to a separate hand-edited .rc file...


The idr_mainframe string contains some seemingly meaningless file associations. Is it used to update registry file assoc?

nyanpasu64 commented 6 years ago

Fixed in #117