N163 wave position setting not working as intended

nyanpasu64 / j0CC-FamiTracker

(Archived, see https://github.com/Dn-Programming-Core-Management/Dn-FamiTracker) Numerous bugfixes for 0CC-FamiTracker (based off 0.3.14.5).

https://github.com/Dn-Programming-Core-Management/Dn-FamiTracker

GNU General Public License v2.0

15 stars 2 forks source link

N163 wave position setting not working as intended #3

Closed nyanpasu64 closed 6 years ago

nyanpasu64 commented 6 years ago

http://hertzdevil.info/forum/index.php/topic,10.0.html ch2 mistakenly concludes there isn't room, when Z31+. tested on 0.3.14.5 and master.

When you switch instruments, 0CC doesn't realize the wave size changed until 1 row afterwards. This results in incorrect checking of whether Zxx is allowed. If not allowed, the previous Zxx remains (even if OOB).

Test Case: n163-zxx-validation.zip Bug analysis: https://github.com/jimbo1qaz/0CC-FamiTracker/wiki/N163-Zxx

nyanpasu64 commented 6 years ago

ChannelsN163.cpp: if (EffParam + (m_iWaveLen >> 1) > 0x80 - 8 * m_iChannels) break; CChannelHandlerN163::HandleEffect uses m_iWaveLen from previous frame.

nyanpasu64 commented 6 years ago

Bug appears on HertzDevil master:

Fixed before v0.3.15.1.
Broken again, between da6767c and bf57728.
da6767c only works if the instrument is on row 0. Moving both instrument and Zxx down breaks again!

Test Case: n163-zxx-validation.zip

Row 0 is fixed.
Row 4 is broken on 0.3.15.1 and da6767c (aka always broken).

Bug analysis: https://github.com/jimbo1qaz/0CC-FamiTracker/wiki/N163-Zxx