nyaruka / floweditor

Graphical flow editor for the TextIt platform.
Other
71 stars 40 forks source link

Canvas Zoom #233

Closed ycleptkellan closed 6 years ago

ycleptkellan commented 6 years ago

Issue to document our thoughts on adding the ability to zoom the canvas and how we'd like to see it implemented.

Initial notes:

ycleptkellan commented 6 years ago

@ericnewcomer looks like we'll want the toolkit edition of jsPlumb if we want mouse wheel/trackpad zooming out of the box. The community edition's setZoom method could work if we added a zoom in/out widget like the second option above, but the gesture/mouse wheel zooming seems more user-friendly. What are your thoughts?

ericnewcomer commented 6 years ago

Only concern there is how licensing something might impact our bundling options. Just adds a new element of consideration to make sure we are honoring any restrictions there.

My gut is that we can build our own here using the setZoom hook that we control completely and fully understand / own.

ycleptkellan commented 6 years ago

OK, makes sense. Any strong feelings on the team as to how zooming should be initiated, e.g. hooking into the mouse wheel event or adding a zoom widget?

ericnewcomer commented 6 years ago

I feel like mouse-wheel still doing a vertical scroll would feel the most natural to users (and I think we still want to encourage vertically expanding flows). I also feel that supporting zoom is only a means to ease canvas panning, which we can implement without zoom. So might make sense to start there.

rowanseymour commented 6 years ago

Would be nice if pinching worked as well for all the users (like myself) on trackpads... but clearly not a priority item

ycleptkellan commented 6 years ago

@ericnewcomer Thanks will do.

@rowanseymour Will def look into that 👍