search

nyaruka / gocommon

Common utility library for the TextIt platform.
Other
7 stars 11 forks source link

Refactor `urns` package #119

Closed rowanseymour closed 5 months ago

rowanseymour commented 5 months ago

Trying to...

  1. Fix https://github.com/nyaruka/gocommon/issues/85
  2. Simplify the API (don't have a bunch of type specific things)
  3. For phone numbers.. only do conversion to an international number at parse time and not in Normalize because only at parse time do we typically have the right country code.
  4. Enforce max length of 255 across all schemes
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.12403% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 89.81%. Comparing base (64e21d5) to head (cd756a1). Report is 1 commits behind head on main.

Files Patch % Lines
urns/urns.go 84.84% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## ========================================== - Coverage 90.35% 89.81% -0.55% ========================================== Files 41 42 +1 Lines 1991 1954 -37 ========================================== - Hits 1799 1755 -44 - Misses 154 160 +6 - Partials 38 39 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.