search

nyaruka / gocommon

Common utility library for the TextIt platform.
Other
7 stars 11 forks source link

Add new s3x package to replace storage #131

Closed rowanseymour closed 2 months ago

rowanseymour commented 2 months ago

We're moving away from storages which can be filesystem for testing, S3 for prod... and using S3 clients for everything with minio for local development and CI (and prod if anyone wants).

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (6120347) to head (bf4c5d0).

Files Patch % Lines
s3x/s3.go 74.35% 5 Missing and 5 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ========================================== - Coverage 90.86% 90.41% -0.46% ========================================== Files 45 47 +2 Lines 1707 1752 +45 ========================================== + Hits 1551 1584 +33 - Misses 117 123 +6 - Partials 39 45 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.