search

nyaruka / gocommon

Common utility library for the TextIt platform.
Other
7 stars 11 forks source link

📵 ParseNumber should ignore numbers which are only possible as local numbers #40

Closed rowanseymour closed 3 years ago

rowanseymour commented 3 years ago

Need to be careful leaning on phonenumbers.IsPossibleNumber since it includes local only numbers https://github.com/nyaruka/phonenumbers/blob/5cebec5f23b923a5ffab981e9b1922fa650497b1/phonenumbers.go#L2265

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (434e9e6) into master (979b092) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          19       19           
  Lines         650      650           
=======================================
  Hits          577      577           
  Misses         45       45           
  Partials       28       28
Impacted Files Coverage Δ
urns/utils.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 979b092...434e9e6. Read the comment docs.

rowanseymour commented 3 years ago

we'll get it right one day!