search

nyaruka / gocommon

Common utility library for the TextIt platform.
Other
7 stars 11 forks source link

🖼️ Move custom date formatting code from goflow and add localization support #44

Closed rowanseymour closed 3 years ago

rowanseymour commented 3 years ago

Trying to keep all this in goflow proved awkward because we need to override the formatting of the dates.Date and dates.TimeOfDay types which are in this repo.

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (934dff4) into main (0315a2d) will increase coverage by 1.27%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   88.55%   89.83%   +1.27%     
==========================================
  Files          19       22       +3     
  Lines         673      797     +124     
==========================================
+ Hits          596      716     +120     
- Misses         47       51       +4     
  Partials       30       30
Impacted Files Coverage Δ
dates/parse.go 86.66% <86.66%> (ø)
dates/i18n.go 88.00% <88.00%> (ø)
dates/format.go 98.66% <98.66%> (ø)
dates/date.go 88.88% <100.00%> (+7.93%) :arrow_up:
dates/timeofday.go 71.42% <100.00%> (+6.72%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0315a2d...934dff4. Read the comment docs.