search

nyaruka / goflow

Flow engine for RapidPro/TextIt.
Other
45 stars 20 forks source link

Rework xvalues to be passed by pointer and have a base struct #1216

Closed rowanseymour closed 8 months ago

rowanseymour commented 8 months ago

Currently some are (object, array) and some are passed by value (boolean, number, text) and one is just an interface (error). This makes them all the same.

codecov[bot] commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a2a93f8) 87.69% compared to head (0e48aa2) 87.69%.

:exclamation: Current head 0e48aa2 differs from pull request most recent head 6d692b1. Consider uploading reports for the commit 6d692b1 to get more accurate results

Files Patch % Lines
flows/field.go 42.85% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1216 +/- ## ======================================= Coverage 87.69% 87.69% ======================================= Files 260 260 Lines 10921 10922 +1 ======================================= + Hits 9577 9578 +1 Misses 922 922 Partials 422 422 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.