search

nyaruka / phonenumbers

GoLang port of Google's libphonenumber library
MIT License
1.25k stars 148 forks source link

shortnumber_info: Accept pointer in APIs #115

Closed jefftt closed 2 years ago

jefftt commented 2 years ago

Update shortnumber_info APIs to accept pointers instead of values to avoid copies

codecov-commenter commented 2 years ago

Codecov Report

Merging #115 (44ba426) into main (d9769c3) will not change coverage. The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   48.78%   48.78%           
=======================================
  Files           9        9           
  Lines        2144     2144           
=======================================
  Hits         1046     1046           
  Misses        958      958           
  Partials      140      140
Impacted Files Coverage Δ
shortnumber_info.go 50.63% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9769c3...44ba426. Read the comment docs.