gen needs ssh. change to https

gedw99 commented 5 months ago

https://github.com/nyaruka/phonenumbers/blob/main/cmd/buildmetadata/main.go#L32 requires ssh config etc.

if err := cloneUpstreamRepo("git@github.com:google/libphonenumber.git"); err != nil {
        return err
    }

can just make the string: https://github.com/google/libphonenumber.git

works fine then:

phonenumbers_buildmetadata
Cloning upstream repo... OK
Building number metadata...OK
Building short number metadata...OK
Building region metadata...OK
Building timezone metadata...OK
Building carrier prefix metadata...
 > read 4 mappings for ar
 > read 12 mappings for be
 > read 28950 mappings for en
 > read 34 mappings for fa
 > read 81 mappings for ko
 > read 1035 mappings for ru
 > read 18 mappings for uk
 > read 454 mappings for zh
 > read 366 mappings for zh_Hant
Building geographic prefix metadata...
 > read 6 mappings for ar
 > read 119 mappings for be
 > read 2110 mappings for bg
 > read 21 mappings for bs
 > read 6520 mappings for de
 > read 240 mappings for el
 > read 266086 mappings for en
 > read 1162 mappings for es
 > read 65 mappings for fa
 > read 48 mappings for fi
 > read 501 mappings for fr
 > read 12 mappings for hr
 > read 54 mappings for hu
 > read 505 mappings for hy
 > read 296 mappings for id
 > read 252 mappings for it
 > read 5 mappings for iw
 > read 1400 mappings for ja
 > read 17 mappings for ko
 > read 182 mappings for nl
 > read 49 mappings for pl
 > read 12197 mappings for pt
 > read 126 mappings for ro
 > read 1051 mappings for ru
 > read 7 mappings for sq
 > read 60 mappings for sr
 > read 320 mappings for sv
 > read 27 mappings for th
 > read 83 mappings for tr
 > read 617 mappings for uk
 > read 63 mappings for vi
 > read 130199 mappings for zh
 > read 18 mappings for zh_Hant

norkans7 commented 5 months ago

Thanks @gedw99, we welcome a pull request for that

rowanseymour commented 5 months ago

Have updated, refreshed the metadata and made new release

gedw99 commented 5 months ago

Thankyou @rowanseymour

if you want I can PR the makefile that makes it all easier.

and Thankyou for the fix too on the github URL.

nyaruka / phonenumbers

gen needs ssh. change to https #166