search

nyaruka / phonenumbers

GoLang port of Google's libphonenumber library
MIT License
1.25k stars 148 forks source link

Add GetCarrierWithPrefixForNumber #88

Closed RaMin0 closed 3 years ago

RaMin0 commented 3 years ago

Addresses #87.

nicpottier commented 3 years ago

Looks ok but could you add some tests?

RaMin0 commented 3 years ago

@nicpottier Added in 9a1136c.

codecov-io commented 3 years ago

Codecov Report

Merging #88 (04f5062) into main (1169760) will increase coverage by 0.12%. The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   47.99%   48.12%   +0.12%     
==========================================
  Files           8        8              
  Lines        2046     2049       +3     
==========================================
+ Hits          982      986       +4     
+ Misses        945      944       -1     
  Partials      119      119
Impacted Files Coverage Δ
phonenumbers.go 63.93% <53.84%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1169760...04f5062. Read the comment docs.