nyaruka / rapidpro

RapidPro is a cloud based SaaS allowing organizations to visually build scalable interactive messaging applications.
Other
36 stars 24 forks source link

Catch errors from xlrd reading import rows and return errors with row numbers #5405

Closed rowanseymour closed 1 month ago

rowanseymour commented 1 month ago

Before:

Captura de pantalla 2024-07-17 a la(s) 17 46 39

After:

Captura de pantalla 2024-07-17 a la(s) 17 47 14
sentry-io[bot] commented 1 month ago

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: temba/contacts/models.py

Function Unhandled Issue
try_to_parse UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 193: character maps to ...
Event Count: 5

Did you find this useful? React with a 👍 or 👎

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (242af0b) to head (cccd364).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5405 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 503 503 Lines 25156 25162 +6 ========================================= + Hits 25156 25162 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.