search

nyaruka / rapidpro

RapidPro is a cloud based SaaS allowing organizations to visually build scalable interactive messaging applications.
Other
36 stars 24 forks source link

Allow empty, non-system topics to be deleted #5415

Closed ericnewcomer closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (33b7a0d) to head (8d82365).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5415 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 503 503 Lines 25147 25169 +22 ========================================= + Hits 25147 25169 +22 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

norkans7 commented 1 month ago

We should now allow creating a new topic with the same name as a deleted one https://github.com/nyaruka/rapidpro/pull/5415/files#diff-462b848ead19bdcf6fb248d3fe558d3778c5fbf620cbe1683d030173158b7aecL53

ericnewcomer commented 1 month ago

We should now allow creating a new topic with the same name as a deleted one https://github.com/nyaruka/rapidpro/pull/5415/files#diff-462b848ead19bdcf6fb248d3fe558d3778c5fbf620cbe1683d030173158b7aecL53

Deleted topics are renamed with a uuid, so I don't think this matters. We could add a is_active filter here, but again, don't think it's necessary.