Fixed deprecation and deps

nyaruka / rapidsms-httprouter

Implements a router in the HTTP thread, one message per call.

http://www.nyaruka.com/

40 stars 38 forks source link

Fixed deprecation and deps #7

Closed shanx closed 10 years ago

shanx commented 10 years ago

Fixed deprecation of importing from django.conf.urls.defaults. This will limit the use of rapidsms-httprouter to django 1.4+. This is declared now in the setup.py. Also allowed higher versions of rapidsms to work, most of the times it is best to not strictly version pin in setup.py but allow different versions as per the choice of the user. Also added djtables as dep.

nicpottier commented 10 years ago

I actually have no idea how rapidsms-httprouter plays in the new rapidsms world. A lot of the router stuff changed quite a bit and it may actually not be entirely needed if you are using a new rapidsms.

I'm fine with updating httprouter to work with newer rapidsms'es but are these changes sufficient, all I'm seeing are dependency tweaks.

shanx commented 10 years ago

I was overly enthousiastic, need to dive more into this. Especially with multiple connections handling some seriously backward incompatible stuff was introduced.