Added Amendment Dropdowns

nycapitolcamp / legislative-apps

Apps providing new visualizations to Open Legislation data.

http://nycapitolcamp.github.com/legislative-apps/

9 stars 3 forks source link

Added Amendment Dropdowns #17

Closed abutterworth closed 11 years ago

abutterworth commented 11 years ago

Reworked the way diffs are stored and pushed out to the view. Has a dropdown of amendments for diffing. I'm not sure if this is the desired behavior or not.

GraylinKim commented 11 years ago

Okay this looks great!

I've only got a couple gripes:

It doesn't have the option @stefancrain added to diff against the current law.
In the bill header, also show the sponsor. Bill Id, Sponsor, Title, and Law Section provide a great context for the bill.

Can you fix up those two points before we merge the branch in?

abutterworth commented 11 years ago

Should be good to go now. I didn't understand what Stefan had done with that 'changes in the current law' until I read through it again.

GraylinKim commented 11 years ago

Okay. To me it makes more sense to have "Current Law" + original bill + all amendments but the latest one in the left box and the original bill + all amendments in the right box. Example:

Left Box          Right Box
------------      ----------
Current Law       S7033
S7033             S7033A
S7033A            S7033B
S7033B            S7033C

That way the diff consistently shows what the box on the right changes from the box on the left. If that makes sense to, you can you make it so? I'll merge after that.