nycehs / data-features

Hub pages and data features for the EH Data Portal
0 stars 0 forks source link

changes from team review #14

Closed mmontesanonyc closed 3 years ago

mmontesanonyc commented 3 years ago

I made the following changes:

@cgettings, mind taking a look? Let me know if I missed anything from yesterday's meeting., or if there's anything to add to this branch before we merge into development and continue review.

mmontesanonyc commented 3 years ago

Looks great. I got my NAAQs mixed up so made an edit to clarify 35 (I had 12 in my head), and to add a "That's good!" interpretation (interpretations are always helpful - something about leading a horse to water) to the text.

One last thing we could do, actually, would be to change the above/below class and styles based on which it is. Have it be a purple badge if it's above the standard, and a green one if below (I usually prefer purple/green to stoplight colors). Do you mind adding that in when you get a chance?

I'll fire over a screenshot to the team as an FYI.

mmontesanonyc commented 3 years ago

Great! I also updated based on Sarah's email. Can you please revert the testing value to the 24-hour value, merge into dev, and we'll move review forward? Thanks!