Add and serve development branch

nycehs / data-features

Hub pages and data features for the EH Data Portal

0 stars 0 forks source link

Add and serve development branch #5

Closed mmontesanonyc closed 2 years ago

mmontesanonyc commented 2 years ago

Let's bring this repo in line with some other standards:

create a development branch (create branch form main)
serve that via github pages (via repository settings)

and then we'll adjust our workflow accordingly:

features or fixes can be merged into development to be staged/previewed via githubpages
things merged into main will be ready for primetime/deployment.

@cgettings I assigned this issue to you - let me know if you have a hard time finding these functions.

cgettings commented 2 years ago

@mmontesanonyc re: #5: development branch created, and GitHub pages site modified so it's built from that branch.

mmontesanonyc commented 2 years ago

Perfect. Thanks!

Because of the old branch situation, we still have realtime.html on the main branch still - a small violation of our plan to have main only include things are deployable. So, I'll delete that for now, and we'll keep working on the working branch.

cgettings commented 2 years ago

Sounds good! Question: I closed this issue; is that alright, or should you have closed it after reviewing?

mmontesanonyc commented 2 years ago

I would say that for small stuff it's OK to close things quickly; for more substantive pull requests, it would be best to wait to merge the branch and then close the pull request after a second set of eyes have been on it.