search

nychealth / EH-dataportal

Source code for the Environment & Health Data Portal
https://a816-dohbesp.nyc.gov/IndicatorPublic/
Apache License 2.0
11 stars 5 forks source link

Related Footer & DE related topics #1143

Closed mmontesanonyc closed 1 month ago

mmontesanonyc commented 1 month ago

Related footer:

DE related topics: Separate from 'related content', we should have an area on the Data Explorer page for ingesting other related DE topic pages. Let's start with:

For DE:

For all:

mmontesanonyc commented 1 month ago

Let's continue this work in feature-related-footer even though it's a little unrelated.

Additionally, consistent with feature-related-footer, add related frontmatter for data features and data-explorer content. LMK if we should chat standards for what's the most important related items, but IMO:

mmontesanonyc commented 1 month ago

@etorem - to add in a 'related data' section, check out this commit - I added a partial called related-data.html and referenced it on the template data-explorer/single.html. Now, if a data explorer topic markdown has the relatedData frontmatter in the format that you established it (with both title and url), then that will be ingested here. So, you can go ahead and continue to add relatedData frontmatter (one note, please remove Transportation from this one, since that's not an active page).

image

etorem commented 1 month ago

@mmontesanonyc the links deliver an error when clicked

Screenshot 2024-10-17 at 12 44 12 PM Screenshot 2024-10-17 at 12 45 20 PM
mmontesanonyc commented 1 month ago

@etorem Oh, on the related footer - fixed it. It was a relative path issue. Thanks for noticing!

FYI, I noticed that for the Racial Wealth Gap related footer, one of the Related items has a title/URL mismatch - can you please address that?

  - title: "Why we're working with you to redesign the data portal"
    url: "data-stories/redlining/"
mmontesanonyc commented 1 month ago

One problem in here is that all of the frontmatter on /data-features/rat-mitigation-zones/ and on /key-topics/pests seems proper, but "Pests and Pesticides" link isn't appearing on the RMZ data feature page. I don't know why.

mmontesanonyc commented 1 month ago

FYI @etorem, I merged production into this branch, so the DE display is up to date. Can you go through the Data Explorer content pages and add the relatedData frontmatter? We've got it on Active Design so far.

etorem commented 1 month ago

[like] Emily Torem reacted to your message:

From: M. Montesano @.> Sent: Tuesday, October 22, 2024 5:14:53 PM To: nychealth/EH-dataportal @.> Cc: Emily Torem @.>; Mention @.> Subject: [EXTERNAL] Re: [nychealth/EH-dataportal] Related Footer & DE related topics (Issue #1143)

FYI @etoremhttps://github.com/etorem, I merged production into this branch, so the DE display is up to date. Can you go through the Data Explorer content pages and add the relatedData frontmatter? We've got it on Active Design so far.

— Reply to this email directly, view it on GitHubhttps://github.com/nychealth/EH-dataportal/issues/1143#issuecomment-2429831087, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A54THZ2YQ5YE4ADRIA6GVIDZ42BY3AVCNFSM6AAAAABPSM5LCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZHAZTCMBYG4. You are receiving this because you were mentioned.Message ID: @.***>

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Forward suspect email to @.**@.> as an attachment (Click the More button, then forward as attachment).

Sent from the New York City Department of Health & Mental Hygiene. This email and any files transmitted with it may contain confidential information and are intended solely for the use of the individual or entity to whom they are addressed. This footnote also confirms that this email message has been swept for the presence of computer viruses.

etorem commented 1 month ago

@mmontesanonyc the links don't work if I put the "data-explorer/.." part of the path so I will plan to remove that portion from all of the entries unless there is an easier fix. Including "data-stories/..." does seem to work; and so does "data-features/..."

In the DE related data entries, it duplicates the "Data-explorer" part so that the link does not work: http://localhost:1313/dev-prod/data-explorer/data-explorer/physical-activity/

mmontesanonyc commented 1 month ago

Right - because relatedData is always going to a data-explorer topic, the frontmatter just needs the name of the De topic page.

but related includes content in other areas (data-stories, data-features, neighborhood-reports), so needs that.

mmontesanonyc commented 1 month ago

Merging in and deploying via #1138