nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
11 stars 13 forks source link

Fix: buildings can't be created in the admin UI #445

Closed Andrew-Dickinson closed 3 months ago

Andrew-Dickinson commented 3 months ago

Buildings can't be created in the admin UI right now since it complains that nodes is a required field. You can't even set this field in the UI and it is definitely not required. This fixes that

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.77%. Comparing base (0e1b434) to head (ae91c5d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #445 +/- ## ======================================= Coverage 94.76% 94.77% ======================================= Files 101 102 +1 Lines 5025 5030 +5 ======================================= + Hits 4762 4767 +5 Misses 263 263 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-Dickinson commented 3 months ago

Yeah the join form still works because it's not technically a django form object, so we bypass the Building form validation logic