Refactor: Group External API urls into a single file

nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans

https://db.mesh.nycmesh.net

MIT License

8 stars 13 forks source link

Refactor: Group External API urls into a single file #453

Open Andrew-Dickinson opened 1 month ago

Andrew-Dickinson commented 1 month ago

Group the URL constants we use to refer to external services into a single file: meshapi/util/outbound_apis.py so that we have a single place to check for external deps.

Might also be a good time to make sure all of our external calls are mocked at testing time (the join form in particular has an issue with this, see #378)

Andrew-Dickinson commented 1 month ago

From a comment here: https://github.com/nycmeshnet/meshdb/pull/449#discussion_r1703619643