codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 98.03922% with 4 lines in your changes missing coverage. Please review.
Project coverage is 95.06%. Comparing base (
632db02) to head (534d1d5).
| Files | Patch % | Lines |
|---|---|---|
| src/meshapi/admin/access_point.py | 88.88% | 3 Missing :warning: |
| src/meshapi/models/devices/access_point.py | 90.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #457 +/- ## ========================================== + Coverage 94.99% 95.06% +0.07% ========================================== Files 105 110 +5 Lines 5214 5310 +96 ========================================== + Hits 4953 5048 +95 - Misses 261 262 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Per #383, we have resolved to reduce the amount of data we store about devices and instead mostly defer to UISP. This PR implements this reduction in information storage.
Unfortunately in order to eliminate lat/lon from device and still maintain the ability to show green dots on the website map in the right place, we have to add another sub-class of device called
AccessPoint(similar toSector) which allows the lat/lon overrides in order to move the dot around on the mapI will write an ongoing UISP import Celery worker in a follow-up PR to fully complete #383, but this gets us almost all the way there