nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.mesh.nycmesh.net
MIT License
8 stars 13 forks source link

Fix: local dev doesn't work with Redis #458

Closed Andrew-Dickinson closed 3 weeks ago

Andrew-Dickinson commented 1 month ago

Unit tests don't pass locally on main lol

Celery tries to connect to redis://localhost:6379/0 but that port isn't forwarded to the system from the container

Andrew-Dickinson commented 1 month ago

@james-otten you said I need to change something else when we modify this file?

james-otten commented 1 month ago

@james-otten you said I need to change something else when we modify this file?

Can we not merge this until after grand goes away. In this case no chance needed.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.90%. Comparing base (9f51cc8) to head (c211231).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #458 +/- ## ======================================= Coverage 92.90% 92.90% ======================================= Files 62 62 Lines 2311 2311 ======================================= Hits 2147 2147 Misses 164 164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-Dickinson commented 1 month ago

Sure no worries

james-otten commented 3 weeks ago

Already happened xD

Andrew-Dickinson commented 3 weeks ago

Whoops :(