search

nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.mesh.nycmesh.net
MIT License
8 stars 13 forks source link

Use install number for NN if possible #464

Closed Andrew-Dickinson closed 3 weeks ago

Andrew-Dickinson commented 1 month ago

Currently, if you put in an old install number, like 5001 to the NN form, MeshDB assigns a lower NN to that based on availability. This is likely confusing, since volunteers would expect 5001 to be used as the NN in this case since it is <8192. This PR adds a check for this case, and a test to cover both the case that 5001 has already been given out, and the case that it has not

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.90%. Comparing base (fc76129) to head (2beec0b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #464 +/- ## ========================================== + Coverage 92.76% 92.90% +0.13% ========================================== Files 62 62 Lines 2308 2310 +2 ========================================== + Hits 2141 2146 +5 + Misses 167 164 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-Dickinson commented 3 weeks ago

Tests failing due to unrelated issue with DOB APIs. Resolved in #475