nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.mesh.nycmesh.net
MIT License
8 stars 13 forks source link

Add test case for apartment included in address line 1 #491

Closed Andrew-Dickinson closed 2 weeks ago

Andrew-Dickinson commented 3 weeks ago

Adds a test case for when the member shoves their apartment into address line 1. Had a shower thought that perhaps this would break things (it does in the existing google maps parser -> lat/lon -> BIN workflow that the spreadsheet uses). We appear to be immune to this failure though, so this test is just a regression to make sure it stays that way.

Note that here we are mocking out the call to the city API and assuming they continue to handle this case as we expect. Perhaps this case should be included in an integration test or a canary (#442 ?) so that we can validate this continues to be the case

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.94%. Comparing base (c30dadc) to head (001b5e4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #491 +/- ## ======================================= Coverage 92.94% 92.94% ======================================= Files 64 64 Lines 2325 2325 ======================================= Hits 2161 2161 Misses 164 164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.