nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Fix: admin map nav broken for buildings, links, devices & loses #576

Closed Andrew-Dickinson closed 2 months ago

Andrew-Dickinson commented 2 months ago

Fixes #560

Forgot to update this stuff in the UUID overhaul (#506)

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.94%. Comparing base (b92237f) to head (3ef4ff4). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #576 +/- ## ======================================= Coverage 93.94% 93.94% ======================================= Files 75 75 Lines 3055 3055 ======================================= Hits 2870 2870 Misses 185 185 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-Dickinson commented 2 months ago

Hmm we can't easily do a UX test without some heavyweight stuff (DDog, Selenium, etc.). It might be good to have JS unit tests though. Let me see if there's a relatively painless way to do that

Andrew-Dickinson commented 2 months ago

Okay so it turns out there is not. Trying to test browser JS code in Node really sucks, and I'm not good enough at javascript to do it without stacking crappy workarounds several layers deep. No tests for you

WillNilges commented 2 months ago

womp womp