search

nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Fix: exports get captured by captive nav and don't download #601

Closed Andrew-Dickinson closed 1 month ago

Andrew-Dickinson commented 2 months ago

Whoops, we broke file downloads when we captured form based nav in #486, this adds an exception for file download so that these are not intercepted

Fixes #597

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.03%. Comparing base (e8ecd33) to head (a490f53). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #601 +/- ## ======================================= Coverage 94.03% 94.03% ======================================= Files 75 75 Lines 3086 3086 ======================================= Hits 2902 2902 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-Dickinson commented 1 month ago

Absolutely not, already went down that road in #576, doing tests for code like this really really sucks