nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Fix: nodes without active installs are hidden on the map #606

Closed Andrew-Dickinson closed 1 month ago

Andrew-Dickinson commented 2 months ago

This filter dates back all the way to before we had a node object, and the following code is all capable of handling the "only inactive installs" case. It's blocking the display of the nodes we fixed in #564 (like NN238 and NN525), so it seems we should remove it

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.03%. Comparing base (e23ec56) to head (af31587). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #606 +/- ## ========================================== - Coverage 94.03% 94.03% -0.01% ========================================== Files 75 75 Lines 3087 3086 -1 ========================================== - Hits 2903 2902 -1 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.