Closed WillNilges closed 1 month ago
Attention: Patch coverage is 98.03922%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 94.20%. Comparing base (
59cc0de
) to head (202fea9
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/meshapi/views/forms.py | 97.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Idea: Instead of logging PII, add some marker to the join form log expressing that there was a problem. That would require appending to an existing S3 object in meshforms, since it would save the submission immediately upon entry.
Yeah i think i already thought of this but http code
I think now all's I gotta do is update Meshforms. Having just spent 30+ hours learning more React, I have i d e a s.
Maybe I could include the PII in the Notes of the created user as well...?
This is almost done, but I'm seeing some inconsistencies with how the phone number parsing works and how it is stored in the DB. For example, I see every phone number stored like +1 555-555-5555
, but that format is "corrected" in the join form (seemingly by the phonenumbers lib were using) to +1555-555-5555
but it shows up as the former in SQL.
Maybe Django is formatting it after the fact? IDK I need to do some more testing.
>>> print(phonenumbers.format_number(phonenumbers.parse("+1 614-307-4056", "US"), phonenumbers.PhoneNumberFormat.INTERNATIONAL))
+1 614-307-4056
>>> print(phonenumbers.format_number(phonenumbers.parse("+1614-307-4056", "US"), phonenumbers.PhoneNumberFormat.INTERNATIONAL))
+1 614-307-4056
yolo'ing it with approval to do so from @Andrew-Dickinson
Closes https://github.com/nycmeshnet/meshforms/issues/56