nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Fix: zip code validation only applies to non-NYC addresses #629

Closed Andrew-Dickinson closed 1 month ago

Andrew-Dickinson commented 1 month ago

The zip code validation applied in #604 only applies to non NYC addresses. We actually want to do this for all addresses, so that a mistaken address falls back to pelias parsing (slack thread with an example here)

This PR moves the logic to happen regardless of if we use OSM or the NYC DOB API to do the address validation

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.03%. Comparing base (678012b) to head (4cd452d). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #629 +/- ## ======================================= Coverage 94.03% 94.03% ======================================= Files 75 75 Lines 3086 3086 ======================================= Hits 2902 2902 Misses 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.