search

nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Cleanup env vars #684

Closed james-otten closed 2 days ago

james-otten commented 2 weeks ago

Resolves #535

Cleanup unused vars.

After merging this, remove them from the environments

Andrew-Dickinson commented 2 weeks ago

How are backups configured?

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.19%. Comparing base (fb4ca0f) to head (6194f1c). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #684 +/- ## ======================================= Coverage 94.19% 94.19% ======================================= Files 80 80 Lines 3293 3293 ======================================= Hits 3102 3102 Misses 191 191 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

james-otten commented 2 weeks ago

How are backups configured?

https://github.com/nycmeshnet/meshdb/blob/main/src/meshdb/settings.py#L287 https://github.com/nycmeshnet/meshdb/blob/main/src/meshapi/tasks.py#L24

Andrew-Dickinson commented 1 week ago

We might want to bring these back as part of the fix for #694 right?

And #695

WillNilges commented 5 days ago

Yeah we should look at those and make sure this won't break anything.

james-otten commented 2 days ago

I think these will come back :'(