nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Email Validation should return 5xx when we fail to validate the email #692

Open WillNilges opened 2 weeks ago

WillNilges commented 2 weeks ago

When we can't reach the internet to get the email, this returns 400. That's wrong. It should be 500 because it's our fault. I've seen this reject valid emails because of this and it makes testing offline impossible unless you mock it.

https://github.com/nycmeshnet/meshdb/blob/main/src/meshapi/validation.py#L22