nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Fix: slack spam due to rotating UISP link UUIDs #700

Closed Andrew-Dickinson closed 2 weeks ago

Andrew-Dickinson commented 2 weeks ago

UISP randomly changes the UUID assigned to certain links, for seemingly no reason. This change detects that situation, and updates our reference, rather than creating a new link object.

There are some edge cases to consider around situations where there are multiple links between a given pair of devices, but the unit tests cover them

Closes #688

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.19%. Comparing base (2f32034) to head (0d0496f). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #700 +/- ## ========================================== - Coverage 94.21% 94.19% -0.02% ========================================== Files 80 80 Lines 3286 3293 +7 ========================================== + Hits 3096 3102 +6 - Misses 190 191 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.