nycmeshnet / meshdb

A convenient, stable, and sane database for tracking Members and Nodes for use with robots and humans
https://db.nycmesh.net
MIT License
12 stars 14 forks source link

Add devices names to link.__str__ for "self links" #703

Closed Andrew-Dickinson closed 2 days ago

Andrew-Dickinson commented 1 week ago

This may be a bit controversial since it makes things a bit bulky at times, but looking at the string representations for "self links" in slack is very confusing.

NN7489 -> NN7489 is so much more confusing than nycmesh-7489-epr7 -> nycmesh-7489-north

For now, we only include the device names for self-links (links between devices within a single node)

This heterogenous format does look a bit messy at times, but results in a lot more clarity for single links in isolation

Screenshot 2024-11-09 at 18 48 45

Also switches to a double headed arrow to indicate that links are not directional

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.11%. Comparing base (df26131) to head (7c97877). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #703 +/- ## ========================================== + Coverage 94.06% 94.11% +0.04% ========================================== Files 82 82 Lines 3406 3415 +9 ========================================== + Hits 3204 3214 +10 + Misses 202 201 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

WillNilges commented 5 days ago

I would be OK with changing it to the device name everywhere, since all devices ought to have the NN in the name anyway.

Andrew-Dickinson commented 4 days ago

You're sure that isn't too verbose? They're so long....

Andrew-Dickinson commented 2 days ago

Let's keep it this way for now, and if we decide we don't like the inconsistency later we can tweak it