Closed Andrew-Dickinson closed 2 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.11%. Comparing base (
df26131
) to head (7c97877
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
I would be OK with changing it to the device name everywhere, since all devices ought to have the NN in the name anyway.
You're sure that isn't too verbose? They're so long....
Let's keep it this way for now, and if we decide we don't like the inconsistency later we can tweak it
This may be a bit controversial since it makes things a bit bulky at times, but looking at the string representations for "self links" in slack is very confusing.
NN7489 -> NN7489
is so much more confusing thannycmesh-7489-epr7 -> nycmesh-7489-north
For now, we only include the device names for self-links (links between devices within a single node)
This heterogenous format does look a bit messy at times, but results in a lot more clarity for single links in isolation
Also switches to a double headed arrow to indicate that links are not directional