Closed Andrew-Dickinson closed 1 day ago
Attention: Patch coverage is 94.24460%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 94.21%. Comparing base (
1496dbd
) to head (73fb4b0
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/meshweb/views/website_stats.py | 93.54% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
The new graphs aren't identical, but they're really close. The biggest thing that's missing is the little green % diff indicator. I don't think matplotlib can really draw that, but if anyone has tips I would appreciate them
Okay changed it so that we just render the graph in MeshDB. All the header stuff will be done on the website side, but I needed an API in order to expose the total counts publicly (using our standard API for this is a security hazard as the token would need to be public). Having this little JSON API also has the advantage of making it trivial to convert to a frontend graphing framework in the future if desired
Adds an endpoint to render SVG files for the website to display, in the style of the current nycmesh.net/stats page
Also does a bit of refactoring and cleanup in meshweb, we should probably spread the views out into multiple files, and we don't need to use the DRF decorators for non-API views