nycmeshnet / nycmesh-support-bot

Slack chatbot to automate on-demand diagnostics collection for NYC Mesh equipment
MIT License
6 stars 2 forks source link

Brake up nn_stats.sh into smaller scripts #63

Closed andybaumgar closed 1 year ago

andybaumgar commented 1 year ago

I'm in the process of implementing https://github.com/nycmeshnet/nycmesh-support-bot/issues/61, but it's difficult to collapse the multiple traceroute outputs using shell scripts, so I'm planning on braking the large command into pieces I can test and modify with Python.

Andrew-Dickinson commented 1 year ago

👍

On Sun, Jan 29, 2023, 23:47 Andy Baumgartner @.***> wrote:

I'm in the process of implementing #61 https://github.com/nycmeshnet/nycmesh-support-bot/issues/61, but it's difficult to collapse the multiple traceroute outputs using shell scripts, so I'm planning on braking the large command into pieces I can test and modify with Python.

— Reply to this email directly, view it on GitHub https://github.com/nycmeshnet/nycmesh-support-bot/issues/63, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAX6K6LMWBVPVOB2JC5SD43WU5BV3ANCNFSM6AAAAAAUKWCT34 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

andybaumgar commented 1 year ago

I didn't end up needing to doing this yet. It would be nice to be able to do unit tests quickly for individual commands though. I think we'd have to run them on Docker somehow. Maybe I could bundle that with setting up a fully containerized dev environment (currently I just use Docker to test the build, but use local Python for actual dev).

andybaumgar commented 1 year ago

Update: we do the UISP call in pure Python in the analytics code now, so that should be easy to port over.

andybaumgar commented 1 year ago

Process:

This will not work for Grand Street building numbers, but we could simply state that in the prompt if we want.