search

nydus / heroesjson

Extract Heroes of the Storm game data to JSON format
http://www.heroesjson.com
ISC License
44 stars 13 forks source link

Error since Varian Patch #56

Open drude2002 opened 7 years ago

drude2002 commented 7 years ago

Getting the following error since the Varian Patch:

Clearing 'out' directory... Copying latest .build.info file... Extracting 108 needed files... Loading data...

Processing heroes... Processing hero: Azmodan (Azmodan) Sub-units: Azmodan [ 'Azmodan' ] Processing hero: Li Li (LiLi) Sub-units: LiLi [ 'LiLi' ] Processing hero: Abathur (Abathur) Alternate: AbathurSymbiote Sub-units: Abathur [ 'Abathur', 'AbathurSymbiote' ] Failed to parse: Behavior,AbathurEvolveMonstrosityDamageReduction50,ArmorModification.ArmorSet[Minion].ArmorMitigationTable[Basic] (Turn an allied Minion or Locust into a Monstrosity. When enemy Minions near the Monstrosity die, it gains 5% Health and 5% Basic Attack damage, stacking up to times. The Monstrosity takes % less damage from non-Heroic enemies.Using Symbiote on the Monstrosity allows you to control it, in addition to Symbiote's normal benefits. This Ability can be reactivated to automatically cast Symbiote on your Monstrosity.) TypeError: Cannot read property 'get' of undefined

I've manually added a fix for Behavior,AbathurEvolveMonstrosityDamageReduction50,ArmorModification.ArmorSet[Minion].ArmorMitigationTable[Basic] in Shared.C but it then fails on another hero etc etc

Any ideas?

Reasno commented 7 years ago

I am seeing this error too. Any updates?

jnovack commented 7 years ago

have you submitted a patch for it?

anysomeoneelse commented 7 years ago

I am having the same issue!

LeoLeal commented 7 years ago

I am working on a fix and update for the latest content. I'm working on the code to try to diminish the number of entries in the C.js files with custom values for the Modifiers and heroes data.

2017-01-04 18:47 GMT-02:00 anysomeoneelse notifications@github.com:

I am having the same issue!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nydus/heroesjson/issues/56#issuecomment-270482150, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy8reAVaajJ0pTqEcEj7eAI9f4IOT8gks5rPAV7gaJpZM4K8u3p .

LeoLeal commented 7 years ago

This is happening on my free time, so keep It cool. If you can help, It would be appreciated.

2017-01-04 21:35 GMT-02:00 Leonardo Leal leoleal@leoleal.com.br:

I am working on a fix and update for the latest content. I'm working on the code to try to diminish the number of entries in the C.js files with custom values for the Modifiers and heroes data.

2017-01-04 18:47 GMT-02:00 anysomeoneelse notifications@github.com:

I am having the same issue!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nydus/heroesjson/issues/56#issuecomment-270482150, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy8reAVaajJ0pTqEcEj7eAI9f4IOT8gks5rPAV7gaJpZM4K8u3p .

anysomeoneelse commented 7 years ago

Not sure if I have enough insight, but if you have an easy task, I would be happy to help.

LeoLeal commented 7 years ago

I already know what to do... Just need time to make it right.

Sometimes blizzard puts just one subnode in a modifier but the game asks for an index higher than zero. Somehow the game works that out. I'll just make the script test the length and if the index is out of bounds, get the last item and test if it's coming right.

Em 5 de jan de 2017 8:41 AM, "anysomeoneelse" notifications@github.com escreveu:

Not sure if I have enough insight, but if you have an easy task, I would be happy to help.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nydus/heroesjson/issues/56#issuecomment-270615081, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy8rWVRpp4MsDt_VK1gfoEBtny0Wp84ks5rPMjQgaJpZM4K8u3p .

anysomeoneelse commented 7 years ago

Which File would I need to alter to fix this problem?

herrvigg commented 7 years ago

hello, i tried to run this extractor for the first time. Just to see i skipped Abathur but after that i encountered some other errors for Raynor, Tyrande and some kind of warnings for Tassadar. So far i have no idea what the state of the project is so i gave up.

See errors here : errors.txt

herrvigg commented 7 years ago

@anysomeoneelse the error is raised in the main generate.js file. It's the first time i tried this project so i have no clue how to fix it yet.

But if you want to skip an hero simply as i did, look at the file shared/C.js and add the hero id to the list in this constant here :

exports.SKIP_HERO_IDS = ["GreymaneWorgen", "ChoGallBundleProduct"];

As said, there are many other issues after Abathur, so i gave up at the moment.

crorella commented 7 years ago

Any idea if this project is being maintained anymore?

LeoLeal commented 7 years ago

Feel free to take it from here... I discontinued commiting on this project in favor of working on a new one, using better practices. It is still too early for a release, but at some point it will be released for the open source community. :)

Em 31 de mai de 2017 2:12 PM, "Cristian Orellana" notifications@github.com escreveu:

Any idea if this project is being maintained anymore?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nydus/heroesjson/issues/56#issuecomment-305254844, or mute the thread https://github.com/notifications/unsubscribe-auth/ABy8rTYQIwGYJ0rRkU1WjVKnxWxod4LWks5r_Z-XgaJpZM4K8u3p .

crorella commented 7 years ago

obrigado @LeoLeal

jnovack commented 7 years ago

I am no longer actively maintaining it.

If someone has a patch, submit it. That's the beauty of open source. If someone has something better, use it. That's the beauty of open source.

crorella commented 7 years ago

I added all the new bosses up to DVa, but for the most part I have no idea what I was doing, just unblocking the errors by using the logic in place to replace XML paths. I'll submit a diff soon.