search

nyergler / nested-formset

Nest Django formsets for multi-level editing.
BSD 3-Clause "New" or "Revised" License
87 stars 21 forks source link

Added missing keyword arguments to factory and accompanying tests #22

Closed rfj001 closed 8 years ago

rfj001 commented 8 years ago

I just added keyword arguments that for some reason got left out of the factory function definition (fk_name, min_num, validate_min), and added tests making sure they are getting passed in now.

I also reordered the kwargs dictionary to match the order of the arguments in the function call. Seemed to make more sense this way.

nyergler commented 8 years ago

Thanks, @rfj001. This actually addresses #18.

I suspect those kwargs were left out because they were added to Django after the initial implementation. Looks like CI broke due to some configuration issues. I've fixed that on master; I wonder if you'd be willing to remove the Django version checks and rebase?

Thanks!

nyergler commented 8 years ago

I rebased onto master and merged this. Thanks, @rfj001 !