Closed CarterLi closed 9 years ago
Seems that this plugin doesn't like ESLyric. The music plays fine if I disable "foo_uie_eslyric.dll"
But... What's happenning with the progress bar?
foo_thbgm will hook the progress bar because all touhou BGM's can loop It's a main feature of foo_thbgm
Can I disable the inf-looping feature? Any idea with the compatibility of ESLyric?
sure, you can set loop_count to 1 in the playback menu
Aha, finally i found the issue about ESLyric.
That crazy plugin will try to iterate all other plugin's get_info interface when playing musics. This is very hackish and may conflict with many other plugins. I also checked with the source code of several other lyrics plugins. They never to this and will cache music's information when loading the music files.
You can also see in the stack dump. foo_uie_eslyric can't parse the return data from foo_thbgm because it can't recognize ZUN's particular WAVE head. Thus cause the crash.
Anyway, if you really need to use ESLyric, I can also do a test build for you to forbid ESLyric visiting foo_thbgm's interface.
Anyway, if you really need to use ESLyric, I can also do a test build for you to forbid ESLyric visiting foo_thbgm's interface.
Good! But instead of "forbiding ESLyric visiting foo_thbgm's interface", could you return some data which is not THAT special, to make ESLyric ignore it safely. It's always not a good idea to hack code for some specified things since other plugins may have the same issue
Yes, I'll do these work this weekend, only because the modification has no downsides. I still don't know why a lyrics plugin need to call other plugin's interface directly.
dump file uploaded: http://pan.baidu.com/s/1mgqYACS PWD: 5dd9
Detail information updated on the thread of Eslyric in Baidu Tieba http://tieba.baidu.com/p/2370754361?pid=68658226844&cid=68687715638#68687715638
now Eslyric can read music data properly and will no longer conflict with each other, plz check the latest build and confirm
Confirmed, thanks
Tested th13, th14 and th14.3. All of them crashes foobar2000. But th13.5 and th14.5 works fine
Plugin downloaded from: http://bbs.nyasama.com/forum.php?mod=viewthread&tid=47702 Version: foobar2000 1.3.8 ( Chinesized by Asion ) with foobox 4.1
Crash log: